[rant]
It's amazing how many problems a single wrong line of code can cause... All the problems people are having with jEmplode and playlists not being all removed properly is a single line of code that accidentally modified a list while something else was enumerating it ... In the spirit of useless code, Java decided it was best to stay silent there and just let me stumble through hours of annoying debugging rather than just throw an exception and let me know that i've done a bad thing. It's amazing that in the year 2002 the same braindead problems go undetected.

Oh well.
[/rant]

Mike

emplode.protocol.do_the_wrong_thing(), huh?

Don't tell me you hit the "old" ArrayList problem ?
<quote>
java.util
Class ArrayList:
Note that this implementation is not synchronized.
...
...the list should be "wrapped" using the Collections.synchronizedList method.
</quote>

You are not the first one to hit this problem.
And I think you won't be the last.

Good that you found it !

Oh no .. this is even more sinister than normal synchronization... And actually, I think ArrayList may not suffer from this problem I ran into, but I am forced to use Vector to maintain 1.1 compatibility.

Basically, make a call to .elements() and start going through the Enumeration. While enumerating the elements, modify the Vector. It silently works and just screws the Enumeration all up (i.e. off-by-one's, etc). I _think_ that ArrayList (and the new collections) throw a ConcurrentModificationException.... But not our old retarded friend Vector.

The actual deal was that while enumerating dirty nodes during synchronization, I clean up after synching each node. Well, the cleanup for an FIDDeleted is to actually complete the deletion and remove it from memory. This was pretty indirect, but what it meant was that ultimately I was changing the Vector of nodes that I was in the middle of enumerating. I changed the implementation instead to just mark it setDirty(false) and just leave it in memory. If the sync succeeds, it will just reload the database anyway, so this code is really only there to handle cancelling in the middle of a sync.

Bleaugh.

ms