Well, um, yeah, the amended version of the patch looks ok. I guess I'll dig the GPS out again and try.

Looks like read() on the serial port now returns EIO.

Hm. So, I commented out the pgrp line again and reverted the change to tty_check_change back to what it was in 363, and I still lose. I very definitely won in 363 with just the pgrp change. I guess I should diff 363 to 367.

Hm.
in read_chan I see
else if (current->pgrp != tty->pgrp) {
if (is_ignored(SIGTTIN) ||
is_orphaned_pgrp(current->pgrp))
return -EIO;
kill_pg(current->pgrp, SIGTTIN, 1);
return -ERESTARTSYS;
}
I wonder if SIGTTIN is ignored. This check of course bypasses the thing you patched.

Make read_chan be symmetric with tty_check_change.

--- drivers/char/n_tty.c 11 Oct 2003 22:14:12 -0000 1.2
+++ drivers/char/n_tty.c 10 Feb 2004 06:33:05 -0000
@@ -956,7 +956,8 @@
current->tty == tty) {
if (tty->pgrp <= 0)
printk("read_chan: tty->pgrp <= 0!\n");
- else if (current->pgrp != tty->pgrp) {
+ else if ((current->pgrp != tty->pgrp) &&
+ (tty->device != MKDEV(TTY_MAJOR,65))) {
if (is_ignored(SIGTTIN) ||
is_orphaned_pgrp(current->pgrp))
return -EIO;

Okay. v368 will have this change in a few minutes.

Thanks Mark,

The Charcoalgray99 Empeg web (Now Playing Info) was also broken after my upgrade to Alpha6 and HiJack V363. But it works now again...

bye

Okay. v368 will have this change in a few minutes.

Tested! It works! Mark and Derrick, thanks very much for your time and your attention to detail. Too cool.

The Charcoalgray99 Empeg web (Now Playing Info) was also broken after my upgrade to Alpha6

Yes, I posted a note about this in the Merry Christmas thread (which is really the v3alpha thread).

Basically, v3alpha6 has the two serial streams (console messages vs. output->notify messages) reversed from normal somewhere. I haven't the foggiest how/why, but I did recently just update Hijack to reverse it's processing of them internally to compensate, whenever running a v3alpha release. Very peculiar.

Cheers

I didn't really follow all the technicalities of this thread, but should telnetd be broken as of Hijack v372 ?
The connection is killed immediately.

Probably not. I'm telnetted in now, seems to not be dying

Crap. That means I screwed something up when upgrading to v3a7. I wonder what though - the connection is made so the server is running...

You zapped all the ttys. Run the devs script again.

Doh! Thanks. I'd completely forgotten about that little detail.